Skip to content

Replaced newline-dependent CMS parser with less breakable regex parser - #52

Open
maxnbk wants to merge 59 commits into
shidarin:feature/parse_cmxfrom
maxnbk:feature/parse_cmx
Open

Replaced newline-dependent CMS parser with less breakable regex parser#52
maxnbk wants to merge 59 commits into
shidarin:feature/parse_cmxfrom
maxnbk:feature/parse_cmx

Conversation

@maxnbk

@maxnbk maxnbk commented Oct 15, 2015

Copy link
Copy Markdown

No description provided.

@shidarin

Copy link
Copy Markdown
Owner

Most excellent. While the CMX parser doesn't currently have unittests (which is why there hasn't been a mainline release yet), do you have a CMX example this would fail on? Would love to replicate the failure in testing.

Really appreciate this change, CMX was never tested heavily.

I'll merge it in later tonight.

@maxnbk

maxnbk commented Oct 15, 2015

Copy link
Copy Markdown
Author

Hold off on it, I just received a couple EDLs it'll fail on and I'll update
again. I will ask if I can pass along the EDLs. Mostly it's just minor
semantic ordering issues (sat before sop for example)
Thanks for being responsive :)

On Oct 15, 2015, at 4:55 PM, Sean Wallitsch notifications@github.com
wrote:

Most excellent. While the CMX parser doesn't currently have unittests
(which is why there hasn't been a mainline release yet), do you have a CMX
example this would fail on? Would love to replicate the failure in testing.

Really appreciate this change, CMX was never tested heavily.

I'll merge it in later tonight.


Reply to this email directly or view it on GitHub
#52 (comment).

@maxnbk

maxnbk commented Oct 15, 2015

Copy link
Copy Markdown
Author

Added addl commit to cover more situations and care less what order things are in

@landscape-bot

Copy link
Copy Markdown

Code Health
Repository health decreased by 0.23% when pulling 6e9bc1f on maxnbk:feature/parse_cmx into feae1e5 on shidarin:feature/parse_cmx.

@landscape-bot

Copy link
Copy Markdown

Code Health
Repository health decreased by 0.39% when pulling e1b4913 on maxnbk:feature/parse_cmx into feae1e5 on shidarin:feature/parse_cmx.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.1%) to 95.546% when pulling a193896 on maxnbk:feature/parse_cmx into feae1e5 on shidarin:feature/parse_cmx.

@coveralls

coveralls commented Oct 19, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-5.6%) to 91.06% when pulling ce96c6e on maxnbk:feature/parse_cmx into feae1e5 on shidarin:feature/parse_cmx.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-5.7%) to 90.995% when pulling bec3fb0 on maxnbk:feature/parse_cmx into feae1e5 on shidarin:feature/parse_cmx.

@coveralls

coveralls commented Oct 19, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-7.0%) to 89.686% when pulling 3690b2c on maxnbk:feature/parse_cmx into feae1e5 on shidarin:feature/parse_cmx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants